You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __init__.py currently uses the match statement, which was introduced only in Python 3.10. Unfortunately, this means pygdsm is incompatible with earlier Python versions, in particular on clusters etc. where upgrading may not be straightforward. As far as I could tell, the match statement was in fact the only source of incompatibility with older Python versions, so here my suggestion to replace it with if/else logic instead.
I have verified this works on a local Python 3.6 installation. I have also added the python_requires argument to the setup.cfg file, as I think this is how pip can tell which Python versions are supported. I suppose the version number also has to be bumped before this can be released, but I am not sure exactly how/if you would like to proceed from here : )
Enhanced Compatibility with Older Python Versions
A change was made in the code base of the program to swap out newer "match" statements for more traditional "if-elif" statements. This ensures that the package is usable even for those using older versions of Python programming language.
Explicit Python Version Requirements
A new field was introduced in the configuration file which explicitly states that for the package to work smoothly, a Python version of 3.6 or higher is needed. This takes the guesswork out of determining which versions are compatible with our software.
Extended Language Support in Metadata
We've updated the 'metadata' - essentially the package's 'label' so to speak - to include Python version support for 3.6 through to 3.9. This means our package is now officially stated to work with more recent versions of Python and can reached a broader user base.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
__init__.pycurrently uses thematchstatement, which was introduced only in Python 3.10. Unfortunately, this meanspygdsmis incompatible with earlier Python versions, in particular on clusters etc. where upgrading may not be straightforward. As far as I could tell, the match statement was in fact the only source of incompatibility with older Python versions, so here my suggestion to replace it with if/else logic instead.I have verified this works on a local Python 3.6 installation. I have also added the
python_requiresargument to thesetup.cfgfile, as I think this is howpipcan tell which Python versions are supported. I suppose the version number also has to be bumped before this can be released, but I am not sure exactly how/if you would like to proceed from here : )